This repository has been archived by the owner on Feb 19, 2021. It is now read-only.
Speed up thumbnail generation for PDFs #399
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ly) massive amounts of work
|
This is a simple, and super-handy improvement! Thanks! |
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we only use the first page of the PDF for thumbnail generation, the current method of converting the entire pdf to a series of .png images is wasteful, and can bog down the consumer if dealing with a very long (page-wise) PDF.
This PR uses the
convertbracket syntax to load only the first page, and get the thumbnail from that instead of doing all the pages.