Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Go 1.8 Plug-in Support #557

Closed
wants to merge 1 commit into from

Conversation

akutz
Copy link
Collaborator

@akutz akutz commented May 23, 2017

This patch introduces support for loading Linux shared object (.so) files as Go 1.8 plug-ins. This feature requires Linux.

@akutz akutz self-assigned this May 23, 2017
@akutz akutz requested a review from codenrhoden May 23, 2017 20:02
@akutz akutz force-pushed the feature/go1.8-plugin-support branch 3 times, most recently from 797e14b to a909cdf Compare May 23, 2017 21:48
@codecov-io
Copy link

codecov-io commented May 23, 2017

Codecov Report

Merging #557 into master will increase coverage by 0.14%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #557      +/-   ##
==========================================
+ Coverage   28.42%   28.56%   +0.14%     
==========================================
  Files          34       34              
  Lines        2016     2020       +4     
==========================================
+ Hits          573      577       +4     
  Misses       1381     1381              
  Partials       62       62
Impacted Files Coverage Δ
api/utils/utils_paths.go 88.04% <100%> (+0.54%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b79ec99...c5c2eec. Read the comment docs.

@akutz akutz force-pushed the feature/go1.8-plugin-support branch 9 times, most recently from 8569e83 to e7039f0 Compare May 25, 2017 16:10
This patch introduces support for loading Linux shared object (.so)
files as Go 1.8 plug-ins. This feature requires Linux.
@akutz akutz force-pushed the feature/go1.8-plugin-support branch from e7039f0 to d965df8 Compare May 25, 2017 16:33
akutz added a commit to akutz/libstorage that referenced this pull request Jun 12, 2017
This patch replaces PR thecodeteam#557 and introduces support for type-isolated Go
plug-ins. The 'api/types/v1' package represents an initial version of
the libStorage type system transformed into interfaces for use by
independent, separate module files.
@akutz
Copy link
Collaborator Author

akutz commented Jun 12, 2017

Replaced by #575.

@akutz akutz closed this Jun 12, 2017
akutz added a commit to akutz/libstorage that referenced this pull request Jun 12, 2017
This patch replaces PR thecodeteam#557 and introduces support for type-isolated Go
plug-ins. The 'api/types/v1' package represents an initial version of
the libStorage type system transformed into interfaces for use by
independent, separate module files.
akutz added a commit to akutz/libstorage that referenced this pull request Jun 12, 2017
This patch replaces PR thecodeteam#557 and introduces support for type-isolated Go
plug-ins. The 'api/types/v1' package represents an initial version of
the libStorage type system transformed into interfaces for use by
independent, separate module files.
akutz added a commit to akutz/libstorage that referenced this pull request Jun 15, 2017
This patch replaces PR thecodeteam#557 and introduces support for type-isolated Go
plug-ins. The 'api/types/v1' package represents an initial version of
the libStorage type system transformed into interfaces for use by
independent, separate module files.
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants