Upgrade Symfony vendor to ^6 #65
Conversation
Including one fix: Since Validator ^6 the Doctrine annotation reader needs to be set specifically. @see https://github.com/symfony/validator/blob/6.1/CHANGELOG.md#60
|
@jerowork Is there anything preventing a merge of this, is it required for thecodingmachine/graphqlite-bundle#142 |
|
@aszenz I'm waiting for reviews. PR is ready for sure. |
|
Maybe @oojacoboo can take a look at this |
|
This repo needs a maintainer. I'm busy enough with graphqlite and everything else I have on my plate. We don't use Symfony framework or Laravel or any of the other plugins that support GraphQLite integrations. So, it's more difficult for me to review these. For instance, why was the AnnotationReader added? Is that because it's not loaded by default now? This repo needs to be aware that Doctrine annotations will be deprecated soon as well. What if someone wants to pass in a custom annotation reader that supports any of their custom Doctrine annotations? |
|
@oojacoboo @jerowork bump |
|
@oojacoboo thecodingmachine/graphqlite-bundle#142 is blocked until new version of this package will released |
|
@jroszkiewicz Added v5.0.1 |
Description
This package still needs to be updated to Symfony ^6.
The existing PR #62 (which also aims to SF6) is not complete. It will fail tests due to a missing fix.
Since Validator ^6 the Doctrine annotation reader needs to be set specifically. @see https://github.com/symfony/validator/blob/6.1/CHANGELOG.md#60
Failing
thecodingmachine/graphqlite-bundle:^5.4:The comment @oojacoboo added to #62 is incorrect. Installing
thecodingmachine/graphqlite-bundleto the latest version5.4will fail when using SF6, due to the incompatibility of this packagethecodingmachine/graphqlite-symfony-validator-bridge. The graphqlite bundle 5.4 is thereby broken, as said in thecodingmachine/graphqlite-bundle#137Therefore, hereby a fixing PR to upgrade this bridge to SF6, so that the bundle can be fixed as well.
Changes