Skip to content

Support both Symfony 6 and 7 #80

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 1 commit into from
Jan 22, 2025

Conversation

enricobono
Copy link
Collaborator

@enricobono enricobono commented Jan 21, 2025

With version 7.0.0 we dropped support for Symfony 6, but the latest versions of the main library graphqlite still support both Symfony 6 and 7.

So, with this PR we reintroduce the support for Symfony 6.

@andrew-demb
Copy link
Collaborator

Just checked in local env tests with symfony/validator 6 - it works

@enricobono
Copy link
Collaborator Author

@andrew-demb I as thinking about release this change as version 7.2.0.
Then we could release thecodingmachine/graphqlite-bundle#239 as 7.2.0 as well.

WDYT?

@andrew-demb
Copy link
Collaborator

I'm OK with minor release here.

But I don't see the reason why any change required in the bundle after release here

@enricobono
Copy link
Collaborator Author

enricobono commented Jan 22, 2025

Actually, you are right 😅
My bad. 😄

So, what do you suggest? We can merge the current release and tag it?

@andrew-demb
Copy link
Collaborator

Yes, it is

@enricobono enricobono merged commit dcba8e5 into thecodingmachine:master Jan 22, 2025
@enricobono enricobono deleted the support-symfony-6 branch January 22, 2025 12:34
@enricobono
Copy link
Collaborator Author

Release ready here:
https://github.com/thecodingmachine/graphqlite-symfony-validator-bridge/releases/tag/untagged-90f590612593c7fa2acf

Would you please take a look at it, before we release it?

@andrew-demb
Copy link
Collaborator

@enricobono I'm ok with current state, thanks

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants