FIX: changed openssl functions typehinting from ressource to OpenSSLC…

…ertificate
thecodingmachine · Aug 20, 2022 · 7df7673 · 7df7673
1 parent 6a4c59f
commit 7df7673
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/generated/openssl.php b/generated/openssl.php
@@ -1420,12 +1420,12 @@ function openssl_x509_fingerprint($certificate, string $digest_algo = "sha1", bo
  * certificate and returns an OpenSSLCertificate object for
  * it.
  *
- * @param string|resource $certificate X509 certificate. See Key/Certificate parameters for a list of valid values.
- * @return resource Returns an OpenSSLCertificate on success.
+ * @param \OpenSSLCertificate|string $certificate X509 certificate. See Key/Certificate parameters for a list of valid values.
+ * @return \OpenSSLCertificate Returns an OpenSSLCertificate on success.
  * @throws OpensslException
  *
  */
-function openssl_x509_read($certificate)
+function openssl_x509_read($certificate): \OpenSSLCertificate
 {
     error_clear_last();
     $safeResult = \openssl_x509_read($certificate);

diff --git a/generator/config/CustomPhpStanFunctionMap.php b/generator/config/CustomPhpStanFunctionMap.php
@@ -26,6 +26,7 @@
     'curl_share_errno' => ['int', 'share_handle' => 'CurlShareHandle'],
     'curl_share_setopt' => ['void', 'share_handle' => 'CurlShareHandle', 'option' => 'int', 'value' => 'mixed'],
     'curl_unescape' => ['string', 'handle' => 'CurlHandle', 'string' => 'string'],
+    'openssl_x509_read' => ['OpenSSLCertificate|false', 'x509certdata'=>'OpenSSLCertificate|string'], // this replace ressource by OpenSSLCertificate
     'fgetcsv' => ['array|false|null', 'fp'=>'resource', 'length='=>'0|positive-int', 'delimiter='=>'string', 'enclosure='=>'string', 'escape='=>'string'], //phpstan default return type is too hard to analyse
     //todo: edit the reader to turn 0|1 into int
     'preg_match' => ['int|false', 'pattern'=>'string', 'subject'=>'string', '&w_subpatterns='=>'string[]', 'flags='=>'int', 'offset='=>'int'], //int|false instead of 0|1|false