Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

array_search should not be part of Safe #80

Closed
bolmstedt opened this issue Jan 21, 2019 · 2 comments
Closed

array_search should not be part of Safe #80

bolmstedt opened this issue Jan 21, 2019 · 2 comments

Comments

@bolmstedt
Copy link

array_search says:

Returns the key for needle if it is found in the array, FALSE otherwise.

It is not an error not finding something you search for, therefore it seems to be outside of Safe's scope.
@simPod
Copy link
Contributor

simPod commented Jan 21, 2019

For me: I would rather expect null or thrown exception but definitelly not FALSE.

🤔

@moufmouf
Copy link
Member

o_O You are perfectly right!
I definitely need to fix this!

@bolmstedt bolmstedt mentioned this issue Jan 30, 2019
Closed
@moufmouf moufmouf mentioned this issue Jan 30, 2019
Merged
@versedi versedi mentioned this issue Feb 4, 2019
Closed
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@simPod @bolmstedt @moufmouf