Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

mb_check_encoding should not be part of Safe #88

Closed
bolmstedt opened this issue Jan 30, 2019 · 2 comments
Closed

mb_check_encoding should not be part of Safe #88

bolmstedt opened this issue Jan 30, 2019 · 2 comments

Comments

@bolmstedt
Copy link

mb_check_encoding returns true if the tested string is the correct encoding and false if it's not, which is not an error. I do have to say that the description of the return values on php.net is unclear, but the function's purpose is pretty clear from function description, naming and boolean return value.

What's more, Safe's implementation has void as return type.

I paraphrase what I said on #80: "It is not an error [..], therefore it seems to be outside of Safe's scope."

@moufmouf
Copy link
Member

👍 Completely ok. I'll remove it in next release.

@moufmouf
Copy link
Member

Closed in #90.
Thanks!

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants