Migrating to Rector 0.4 #114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rector 0.4 is the latest Rector version. This PR migrates the generated Rector file to be compatible with Rector 0.4. It introduces a breaking change since the file is no longer compatible with Rector 0.3. I am willing to introduce this breaking change because Rector 0.3 is currently broken. Any install of Rector 0.3 triggers an error right now (and nobody complained about it in Rector issues). I'm therefore assuming that nobody is using Rector 0.3 anymore and migrating to Rector 0.4 without further notice.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rector 0.4 is the latest Rector version.
This PR migrates the generated Rector file to be compatible with Rector 0.4.
It introduces a breaking change since the file is no longer compatible with Rector 0.3.
I am willing to introduce this breaking change because Rector 0.3 is currently broken. Any install of Rector 0.3 triggers an error right now (and nobody complained about it in Rector issues).
I'm therefore assuming that nobody is using Rector 0.3 anymore and migrating to Rector 0.4 without further notice.
Notice: this PR also adds tests to check the correctness of the generated rector file.
Closes #103
Closes #109