Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix: Drop support for unsupported versions of rector/rector #209

Merged
merged 2 commits into from
Mar 18, 2020

Conversation

localheinz
Copy link
Contributor

@localheinz localheinz commented Mar 13, 2020

This PR

  • drops support for outdated versions of rector/rector
  • regenerates files

Replaces #204.

💁‍♂ For reference, see rectorphp/rector#2973 (comment).

@localheinz localheinz mentioned this pull request Mar 13, 2020
1 task
@localheinz localheinz changed the title Fix: Drop support for outdated rector/rector Fix: Drop support for unsupported versions of rector/rector Mar 13, 2020
@moufmouf
Copy link
Member

I'm just starting to realize... Rector 0.6 does not work with any version of PHP anymore, it is completely broken, isn't it?
Because of some dependency issue with a Simplify package?

@moufmouf
Copy link
Member

I'm a bit reluctant to remove support for old versions of Rector (we already did that for Rector 0.3 and it caused problems for some users). But of course, if the package is broken for everybody, it shouldn't be a problem.
@Kharhamel what do you think about this?

@localheinz
Copy link
Contributor Author

@moufmouf

I'm a bit reluctant to remove support for old versions of Rector (we already did that for Rector 0.3 and it caused problems for some users). But of course, if the package is broken for everybody, it shouldn't be a problem.

I wouldn't worry about it:

  • rector/rector is not a direct dependency of thecodingmachine/safe
  • if anyone wants to use thecodingmachine/safe and at the same time use rector/rector to modify their code, they will be able to find a way, for example: use a dedicated composer.json and a corresponding step that installs the required version of rector/rector, and then runs it

@Kharhamel Kharhamel merged commit 8be40b3 into thecodingmachine:master Mar 18, 2020
@localheinz localheinz deleted the fix/rector branch March 18, 2020 09:23
@localheinz
Copy link
Contributor Author

Thank you, @Kharhamel and @moufmouf!

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants