-
-
Notifications
You must be signed in to change notification settings - Fork 155
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Fix fputcsv annotation #318
Conversation
This looks good. The CI error seems to come from a cache error (I had the same on another PR) so I think we can safely merge it. How sure are you of your fix? |
Umh, the PR seems kinda messed up, because the fix was already merged in #316... |
What you mean? Which force push? I only ever force-push to my own branches, never to master. I also fixed the cache, which should solve your CI error. You just need to pull master to benefit from the change. |
GitHub doesn't agree... That's what I see: You force-pushed, erasing 6b3abbe which was @dbrekelmans merging my #316 into master. That's why this PR is messy: it's #316 + https://github.com/thecodingmachine/safe/pull/318/files/9f63c60d5f1e746873629fd5447e6b80f7622770..246d93cd3a7d52d7beb33028918d64de45a24329 |
That's weird. How did I do that. If it is really messed up, the easy way to fix is to simply destroy the commits (but not the changes), stash the changes, start over from a clean master branch and commit. So something like this:
If you need help, we can try to meet on discord and fix it together |
Done! |
Codecov Report
@@ Coverage Diff @@
## master #318 +/- ##
=========================================
Coverage 48.48% 48.48%
Complexity 308 308
=========================================
Files 15 15
Lines 794 794
=========================================
Hits 385 385
Misses 409 409 Continue to review full report at Codecov.
|
Damn i just created a new release. I'll do another one i guess |
During #316 I restricted the type of the
$field
argument, and that triggered my static analysis tools while importing the fix.As shown in https://3v4l.org/ahdmn, the original
fputcsv
function will try to cast everything tostring
, so every scalar is safe, array are risky (they becomeArray
), objects explode, with the exception of stringable ones.