Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

FIX: the generator now ignore the number typehints from phpstan #336

Merged
merged 2 commits into from
Mar 30, 2022

Conversation

Kharhamel
Copy link
Collaborator

No description provided.

@Kharhamel Kharhamel requested a review from dbrekelmans March 29, 2022 16:03
@codecov-commenter
Copy link

codecov-commenter commented Mar 30, 2022

Codecov Report

Merging #336 (9865ec0) into master (68096ae) will increase coverage by 0.12%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##             master     #336      +/-   ##
============================================
+ Coverage     49.30%   49.43%   +0.12%     
- Complexity      312      313       +1     
============================================
  Files            16       16              
  Lines           789      791       +2     
============================================
+ Hits            389      391       +2     
  Misses          400      400              
Impacted Files Coverage Δ
generator/src/PhpStanFunctions/PhpStanType.php 97.82% <100.00%> (+0.04%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 68096ae...9865ec0. Read the comment docs.

@Kharhamel Kharhamel merged commit c4919cd into master Mar 30, 2022
@homersimpsons homersimpsons deleted the removeNUmbers branch March 27, 2023 09:08
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants