-
-
Notifications
You must be signed in to change notification settings - Fork 155
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Update rector-migrate.php to support latest Rector #372
Conversation
Support Rector 0.13.x features mainly RectorConfig
Hello codingmachine team I watched an old PHP talk from 2018 last night they talked about your project safe. I gave it a try following the instructions in your README but the composer require --dev rector/rector installed the latest version of rector which doesn't use the ContainerConfigurator anymore but rather their own RectorConfig. Here is the author official blog post about this change: related blog post of Rector author Thanks for your awesome work have a great day. |
Hey @alexandreelise, looks good to me! If you could fix the failing checks, then everything will be good to merge 👍 |
Hey @dbrekelmans I'll look into it thanks for the feedback. Happy to help as much as I can. |
# Conflicts: # rector-migrate.php
Hey @dbrekelmans I just pushed the changes as you requested can you give a check please? |
I completely forgot to read the CONTRIBUTING guideline. My bad. Now that I red it I followed the steps it should work as expected. Please review @dbrekelmans . Have a great day. |
Happy to contribute. Have a great day @dbrekelmans and thecodingmachine team. Take care. |
Support Rector 0.13.x features mainly RectorConfig