Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

FEATURE: fgetcsv now returns false on end of file #388

Merged
merged 1 commit into from
Sep 13, 2022
Merged

Conversation

Kharhamel
Copy link
Collaborator

this should fix #361

TODO:

  • test the error case

@Kharhamel Kharhamel force-pushed the fgetcsv branch 2 times, most recently from 53a11d1 to 3b5ca30 Compare September 8, 2022 15:38
@codecov-commenter
Copy link

codecov-commenter commented Sep 8, 2022

Codecov Report

Base: 49.24% // Head: 49.24% // No change to project coverage 👍

Coverage data is based on head (fff45e0) compared to base (be78f5b).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff            @@
##             master     #388   +/-   ##
=========================================
  Coverage     49.24%   49.24%           
  Complexity      314      314           
=========================================
  Files            16       16           
  Lines           794      794           
=========================================
  Hits            391      391           
  Misses          403      403           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Kharhamel Kharhamel merged commit dc8df8f into master Sep 13, 2022
@staabm staabm deleted the fgetcsv branch November 28, 2024 10:55
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Safe\fgetcsv throws Exception when csv file ends with a new line
2 participants