Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

FIX: Fix openssl_pkey_get_* functions #409

Merged

Conversation

martinssipenko
Copy link
Contributor

@martinssipenko martinssipenko commented Feb 21, 2023

  • Fixed the input and output of the openssl_pkey_get_private function as starting from PHP 8.0 it accepts:

    • \OpenSSLAsymmetricKey|\OpenSSLCertificate|array|string for $private_key
    • null|string for $passphrase
      and returns OpenSSLAsymmetricKey|false.
  • Fixed the input and output of the openssl_pkey_get_public function as starting from PHP 8.0 it accepts:

    • \OpenSSLAsymmetricKey|\OpenSSLCertificate|array|string for $public_key
      and returns OpenSSLAsymmetricKey|false.
  • Added openssl_pkey_get_details function as it's actually falsy, but was not picked up by automatic code generation because of wording in PHP docs, but now is after this change.

@martinssipenko martinssipenko changed the title FIX: Fix openssl_pkey_get_private function FIX: Fix openssl_pkey_get_* functions Feb 22, 2023
@Kharhamel Kharhamel merged commit 3115ecd into thecodingmachine:master Apr 5, 2023
@Kharhamel
Copy link
Collaborator

Thanks a lot, I will try to deploy this this week end

@martinssipenko martinssipenko deleted the fix-openssl_pkey_get_private branch April 9, 2023 06:52
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants