Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Adding preg_replace to special cases functions #72

Merged
merged 3 commits into from
Jan 10, 2019

Conversation

moufmouf
Copy link
Member

preg_replace returns "NULL" instead of "false" on error.

This PR adds preg_replace to the list of functions.

Closes #71

@@ -6,5 +6,6 @@
return [
'json_decode',
'apc_fetch',
'apcu_fetch'
'apcu_fetch',
'preg_replace',
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe cs-fixer could help?

{
error_clear_last();
$result = \preg_replace($pattern, $replacement, $subject, $limit, $count);
var_dump($result);
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙃

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gee... committed too quickly it seems :)

@coveralls
Copy link

coveralls commented Jan 10, 2019

Pull Request Test Coverage Report for Build 141

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 34.417%

Totals Coverage Status
Change from base Build 138: 0.0%
Covered Lines: 180
Relevant Lines: 523

💛 - Coveralls

@moufmouf moufmouf merged commit 3980192 into thecodingmachine:master Jan 10, 2019
@moufmouf moufmouf deleted the preg_replace branch January 10, 2019 13:46
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants