Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Dropping call_user_func_array from Safe functions #74

Merged
merged 1 commit into from
Jan 11, 2019

Conversation

moufmouf
Copy link
Member

call_user_func_array can legitimately return false.

  • there is no sane way to handle protected methods.

Closes #73

Warning, this PR introduces breaking changes.

@coveralls
Copy link

coveralls commented Jan 11, 2019

Pull Request Test Coverage Report for Build 144

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 34.417%

Totals Coverage Status
Change from base Build 142: 0.0%
Covered Lines: 180
Relevant Lines: 523

💛 - Coveralls

@moufmouf moufmouf merged commit 5687cf3 into thecodingmachine:master Jan 11, 2019
@moufmouf moufmouf deleted the call_user_func branch January 11, 2019 09:03
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants