New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Fixing argument 2 passed to Safe\openssl_sign() must be of the type string, null given #91

Merged

moufmouf merged 2 commits into thecodingmachine:master from moufmouf:openssl_sign

Jan 30, 2019

Member

moufmouf commented Jan 30, 2019

See #86.


          Adding failing test

d7d5622

moufmouf mentioned this pull request

Argument 2 passed to Safe\openssl_sign() must be of the type string, null given #86

Closed


          Fixing handling of write only reference parameters

aff63ae

Member Author

moufmouf commented Jan 30, 2019

This PR actually fixes all the reference parameters that are used to "write only" by making these parameters nullable.

moufmouf merged commit 4a8c8e5 into thecodingmachine:master

moufmouf deleted the openssl_sign branch

January 30, 2019 21:09

coveralls commented Jan 30, 2019

Pull Request Test Coverage Report for Build 159

0 of 0 changed or added relevant lines in 0 files are covered.
27 unchanged lines in 2 files lost coverage.
Overall coverage increased (+1.1%) to 35.436%

Files with Coverage Reduction	New Missed Lines	%
src/PhpStanFunctions/PhpStanParameter.php	4	82.61%
src/Parameter.php	23	49.02%

Totals
Change from base Build 156:	1.1%
Covered Lines:	191
Relevant Lines:	539

💛 - Coveralls

2 similar comments

coveralls commented Jan 30, 2019

Pull Request Test Coverage Report for Build 159

0 of 0 changed or added relevant lines in 0 files are covered.
27 unchanged lines in 2 files lost coverage.
Overall coverage increased (+1.1%) to 35.436%

Files with Coverage Reduction	New Missed Lines	%
src/PhpStanFunctions/PhpStanParameter.php	4	82.61%
src/Parameter.php	23	49.02%

Totals
Change from base Build 156:	1.1%
Covered Lines:	191
Relevant Lines:	539

💛 - Coveralls

coveralls commented Jan 30, 2019

Pull Request Test Coverage Report for Build 159

0 of 0 changed or added relevant lines in 0 files are covered.
27 unchanged lines in 2 files lost coverage.
Overall coverage increased (+1.1%) to 35.436%

Files with Coverage Reduction	New Missed Lines	%
src/PhpStanFunctions/PhpStanParameter.php	4	82.61%
src/Parameter.php	23	49.02%

Totals
Change from base Build 156:	1.1%
Covered Lines:	191
Relevant Lines:	539

💛 - Coveralls

# for free to join this conversation on GitHub. Already have an account? # to comment

Labels

None yet