Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[WIP] Improve return #98

Merged
merged 2 commits into from
Mar 6, 2019
Merged

Conversation

jderusse
Copy link
Contributor

This PR is on top of #96 and should be merged after (or replace #96).

this PR improve the sentence on @return dockblock by removing leading space and comma

ie:

- @return string Returns the uncompressed data,  .
+ @return string Returns the uncompressed data.

the only file changed in that PR is:

 private function removeString(string $string, string $search): string
 {
   $search = str_replace(' ', '\s+', $search);
-  return preg_replace('/'.$search.'/m', '', $string);
+  return preg_replace('/[\s\,]*'.$search.'/m', '', $string);
 }

@coveralls
Copy link

coveralls commented Feb 28, 2019

Pull Request Test Coverage Report for Build 170

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 35.436%

Totals Coverage Status
Change from base Build 160: 0.0%
Covered Lines: 191
Relevant Lines: 539

💛 - Coveralls

@moufmouf
Copy link
Member

moufmouf commented Mar 6, 2019

Sweaaat! This is huge!

@moufmouf moufmouf merged commit 5015fb0 into thecodingmachine:master Mar 6, 2019
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants