Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Fixes #37846 - Support Rails 7.0 #762

Merged
merged 1 commit into from
Oct 23, 2024
Merged

Fixes #37846 - Support Rails 7.0 #762

merged 1 commit into from
Oct 23, 2024
+4 −4

Conversation

ofedoren
Copy link
Member

No description provided.

@ofedoren ofedoren force-pushed the feat-37846-support-rails-7 branch from 66f77e6 to af47b0a Compare September 20, 2024 13:35
@ofedoren ofedoren force-pushed the feat-37846-support-rails-7 branch from af47b0a to 642d6b8 Compare October 10, 2024 12:50
ofedoren
ofedoren commented Oct 22, 2024
View reviewed changes
Copy link
Member Author

@ofedoren ofedoren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm afraid this PR depends on Foreman's one, I don't seem to find to_fs on TimeWithZone in Rails 6.1 :/

ekohl
ekohl requested changes Oct 22, 2024
View reviewed changes
lib/foreman_tasks/cleaner.rb Outdated Show resolved Hide resolved
@ofedoren ofedoren force-pushed the feat-37846-support-rails-7 branch from 642d6b8 to 05c6e26 Compare October 23, 2024 11:34
@adamruzicka adamruzicka merged commit 4f857aa into theforeman:master Oct 23, 2024
23 checks passed
@adamruzicka
Copy link
Contributor

Thank you @ofedoren & @ekohl !

# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@ekohl ekohl ekohl requested changes

@adamruzicka adamruzicka adamruzicka approved these changes

Assignees
No one assigned
Labels
None yet
Projects
No open projects
Rails 7.0
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ofedoren @adamruzicka @ekohl