-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Fixes #37464 - Support Zeitwerk loader #570
Conversation
lib/foreman_openscap/engine.rb
Outdated
config.autoload_paths += Dir["#{config.root}/app/controllers/concerns"] | ||
config.autoload_paths += Dir["#{config.root}/app/helpers/concerns"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do these 2 remain, but you remove the others?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think there is no reason to leave them, removed.
49e64c4
to
b02cd65
Compare
Hmm, not sure why the tests from core are failing here... I had the same errors for plain Foreman, but they got fixed. |
b02cd65
to
cfb0a7f
Compare
I think this may be a relevant failure, coming from STI with interfaces. |
cfb0a7f
to
0155fc8
Compare
@ekohl thanks, it was indeed. Moreover, thanks to that fail we prevented a hidden issue in REX caused by the same issue. I'm afraid there might be still places we didn't catch by the test runs :/ |
0155fc8
to
d23a048
Compare
d23a048
to
8290692
Compare
5fdac30
to
fb1725a
Compare
Ready to merge after theforeman/foreman#10131 is merged, dropped the commit for testing with Foreman PR, the latest run was green: |
fb1725a
to
f517cb2
Compare
f517cb2
to
885082a
Compare
We'll need new releases
|
tasks and REX are done, ansible is pending |
885082a
to
d6e7cb7
Compare
🍏 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note to self: foreman_ansible is a soft dependency so there's no version check that needs to be updated.
WIPRequires: