Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Make managing BIND system group optional #139

Merged
merged 1 commit into from
Apr 25, 2019

Conversation

antaflos
Copy link
Contributor

@antaflos antaflos commented Apr 19, 2019

Add class parameter dns::group_manage which defaults to true, so that
the module keeps managing the system group for BIND ("bind" or "named"),
but allow the user to set it to false. This way the group can be managed
outside of this module's scope.

Fixes GH-140

Copy link
Member

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general it looks correct. Trivial style nitpick which is easier. The type already guarantees it's a proper boolean anyway.

Add class parameter dns::group_manage which defaults to true, so that
the module keeps managing the system group for BIND ("bind" or "named"),
but allow the user to set it to false. This way the group can be managed
outside of this module's scope.
@antaflos antaflos force-pushed the make_group_manage_optional branch from 05bbfe3 to 67d146e Compare April 23, 2019 14:38
@antaflos
Copy link
Contributor Author

Gently bumping this :)

@mmoll mmoll merged commit 1ff131b into theforeman:master Apr 25, 2019
@mmoll
Copy link
Contributor

mmoll commented Apr 25, 2019

merged, thanks @antaflos!

# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Managing of BIND system group should be optional
4 participants