Add manage_service parameter #149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows users to decide whether the module should manage the dns service. The check defaults to true, but in case users want to manage the service autonomously they can. This also solves "duplicate declaration" issues when the service is declared in another .pp file This does not influence package installation.
ekohl
requested changes
Sep 22, 2019
|
@ekohl Ok, I've pointed all the calls to Class['dns::service'] and added tests to dns_init_spec.rb for the manage_service parameter. |
ekohl
approved these changes
Oct 23, 2019
spec/defines/dns_zone_spec.rb
Outdated
| @@ -38,7 +38,7 @@ | |||
| :group => 'named', | |||
| :mode => '0644', | |||
| :replace => 'false', | |||
| :notify => 'Service[named]', | |||
| :notify => 'Class[Dns::Service]', | |||
There was a problem hiding this comment.
A more correct way of checking uses the catalog. I realize this was already incorrect, but I'd appreciate it if you fixed it while changing this part
Suggested change
| :notify => 'Class[Dns::Service]', | |
| ).that_notifies('Class[Dns::Service]') |
|
Sorry about the horrible delay on a one-line fix :/ Should be ok now! :) |
|
merged, thanks @flyingstar16! |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows users to decide whether the module should manage the
dns service. The check defaults to true, but in case users want to
manage the service autonomously they can.
This also solves "duplicate declaration" issues when the service
is declared in another .pp file
This does not influence package installation.