Simplify variables in katello::qpid #119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| $client_cert, | ||
| $client_key, | ||
| $katello_user = $::katello::user, | ||
| $candlepin_event_queue = $::katello::candlepin_event_queue, |
There was a problem hiding this comment.
I don't see this variable in $::katello, the exec below was referencing $::katello::params::candlepin_event_queue Maybe candlepin_event_queue could be a param on the qpid class itself?
There was a problem hiding this comment.
Right now the katello class inherits from params so that way it should be available. By using it this way you can easily make it a real parameter later on.
|
Otherwise, looks good - and thanks, nice cleanup |
|
@stbenjam I believe this is waiting on you |
|
ACK, thanks @ekohl |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.