Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Refs #14858 - removes gutterball #124

Merged
merged 1 commit into from
May 27, 2016
Merged

Refs #14858 - removes gutterball #124

merged 1 commit into from
May 27, 2016

Conversation

cfouant
Copy link
Contributor

@cfouant cfouant commented Apr 27, 2016 •
edited
Loading

@stbenjam
Copy link
Member

Missing one:
./templates/plugin/gutterball/gutterball.yaml.erb

@stbenjam
Copy link
Member

Nitpick, no BZ's in upstream commit messages

@cfouant cfouant mentioned this pull request May 3, 2016
Merged
@cfouant cfouant force-pushed the remove-gutterball branch from 298af1f to 2fb5a67 Compare May 3, 2016 14:42
@cfouant cfouant changed the title fixes #14858 - removes gutterball BZ1315286, BZ1306038 Refs #14858 - removes gutterball BZ1315286, BZ1306038 May 3, 2016
@cfouant cfouant force-pushed the remove-gutterball branch from 2fb5a67 to 89398b9 Compare May 3, 2016 14:58
@cfouant cfouant changed the title Refs #14858 - removes gutterball BZ1315286, BZ1306038 Refs #14858 - removes gutterball May 3, 2016
@cfouant cfouant force-pushed the remove-gutterball branch from 89398b9 to 730380c Compare May 3, 2016 15:00
@cfouant
Copy link
Contributor Author

cfouant commented May 3, 2016

Good eye, thanks @stbenjam

@ekohl
Copy link
Member

ekohl commented May 18, 2016

ACK

@stbenjam
Copy link
Member

Please don't merge any of these yet until we try them together to make sure it works, but from a puppet perspective it is good :)

@stbenjam
Copy link
Member

ACK

@stbenjam stbenjam merged commit c86f16a into theforeman:master May 27, 2016
@cfouant cfouant deleted the remove-gutterball branch May 31, 2016 14:30
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cfouant @stbenjam @ekohl