-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
refresh services when certs change #172
Conversation
... we might want to wait for https://github.com/Katello/puppet-katello/pull/171/files before merging this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree we should first refactor into separate services. That should make the integration cleaner.
manifests/init.pp
Outdated
@@ -171,4 +171,11 @@ | |||
Exec['cpinit'] -> Exec['foreman-rake-db:seed'] | |||
|
|||
User<|title == apache|>{groups +> $user_groups} | |||
|
|||
# lint:ignore:spaceship_operator_without_tag | |||
Certs::Ssltools::Certutil <| |> ~> Service['qpidd'] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can't we catch this in some other way? I'd think the Class['certs::qpid']
would also take care of this.
This commits adds code to refresh services when certs change. Previously, this has been done in puppet-certs module.
Updated in the hope, that it'll fix the pipeline. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ekohl are you OK with this change going in before the service split?
@ehelms I am |
Thanks @timogoebel ! |
This commits adds code to refresh services when certs change.
Previously, this has been done in puppet-certs module.