Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

refresh services when certs change #172

Merged
merged 1 commit into from
Mar 21, 2017
Merged

Conversation

timogoebel
Copy link
Member

This commits adds code to refresh services when certs change.
Previously, this has been done in puppet-certs module.

@timogoebel
Copy link
Member Author

... we might want to wait for https://github.com/Katello/puppet-katello/pull/171/files before merging this.

Copy link
Member

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree we should first refactor into separate services. That should make the integration cleaner.

@@ -171,4 +171,11 @@
Exec['cpinit'] -> Exec['foreman-rake-db:seed']

User<|title == apache|>{groups +> $user_groups}

# lint:ignore:spaceship_operator_without_tag
Certs::Ssltools::Certutil <| |> ~> Service['qpidd']
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't we catch this in some other way? I'd think the Class['certs::qpid'] would also take care of this.

This commits adds code to refresh services when certs change.
Previously, this has been done in puppet-certs module.
@timogoebel
Copy link
Member Author

Updated in the hope, that it'll fix the pipeline.

Copy link
Member

@ehelms ehelms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ekohl are you OK with this change going in before the service split?

@ekohl
Copy link
Member

ekohl commented Mar 21, 2017

@ehelms I am

@ehelms
Copy link
Member

ehelms commented Mar 21, 2017

Thanks @timogoebel !

@ehelms ehelms merged commit 2b52ff9 into theforeman:master Mar 21, 2017
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants