Switch to using qpid bind #177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Relies on theforeman/puppet-qpid#52 |
ehelms
commented
Mar 24, 2017
manifests/qpid.pp
Outdated
| ssl_cert => $client_cert, | ||
| queue => $candlepin_event_queue, | ||
| exchange => 'event', |
There was a problem hiding this comment.
Not ideal to hardcode, but did that for now since this should get more re-factoring as we split things out.
There was a problem hiding this comment.
You could introduce a $candlepin_event_exchange and hardcode the default there. That at least makes it easier to override later on.
|
Updated to add a variable for the candlepin exchange as a placeholder |
ekohl
requested changes
Mar 24, 2017
manifests/qpid.pp
Outdated
| @@ -25,8 +26,9 @@ | |||
| require => Service['qpidd'], | |||
| logoutput => true, | |||
| } ~> | |||
| qpid::bind_event { ['entitlement.created', 'entitlement.deleted', 'pool.created', 'pool.deleted', 'compliance.created']: | |||
| qpid::bind { ['entitlement.created', 'entitlement.deleted', 'pool.created', 'pool.deleted', 'compliance.created']: | |||
There was a problem hiding this comment.
This should now also be qpid::config::bind
ehelms
force-pushed
the
use-bind
branch
2 times, most recently
from
030005a to
8f8def5
Compare
|
Refactored! |
|
Updated per comments |
ekohl
approved these changes
Mar 24, 2017
|
Since theforeman/puppet-qpid#52 is now merged, could you rebase to see if the tests pass? |
|
@ekohl that did the trick, thanks. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.