Fixes #20857 - override post_sync_url #211
Conversation
|
What do you think about using |
sean797
force-pushed
the
post_sync_url
branch
from
7177386 to
200e2de
Compare
|
@ekohl Yea, nice idea. Updated to use |
manifests/application.pp
Outdated
| include ::certs | ||
| include ::certs::apache | ||
| include ::certs::foreman | ||
| include ::certs::pulp_client | ||
|
|
||
| $application_host = $::foreman::foreman_url |
There was a problem hiding this comment.
It might simplify the config template if you define $post_sync_url here.
sean797
force-pushed
the
post_sync_url
branch
from
200e2de to
88b2219
Compare
|
Hows that @ekohl ? |
manifests/application.pp
Outdated
| include ::certs | ||
| include ::certs::apache | ||
| include ::certs::foreman | ||
| include ::certs::pulp_client | ||
|
|
||
| $post_sync_url = "${$::foreman::foreman_url}${deployment_url}/api/v2/repositories/sync_complete?token=${post_sync_token}" | ||
| $application_host = $::foreman::foreman_url |
|
This looks a lot like a change I already wanted to make but hadn't gotten around to :) |
sean797
force-pushed
the
post_sync_url
branch
from
88b2219 to
e30720c
Compare
|
ah, damn! That was left over from before. Thanks @ekohl |
manifests/application.pp
Outdated
| include ::certs | ||
| include ::certs::apache | ||
| include ::certs::foreman | ||
| include ::certs::pulp_client | ||
|
|
||
| $post_sync_url = "${$::foreman::foreman_url}${deployment_url}/api/v2/repositories/sync_complete?token=${post_sync_token}" |
There was a problem hiding this comment.
I'm surprised this works. Usually we have ${::foreman::foreman_url}. The tests appear to pass so this is valid syntax?
There was a problem hiding this comment.
Interesting, it must be. I was actually a typo so I've update to match the rest of our code base.
sean797
force-pushed
the
post_sync_url
branch
from
e30720c to
8faf834
Compare
|
Thanks! This removes an item from my (mental) list of things to fix. |
No description provided.