Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix Stdlib::HTTPSUrl type name #330

Merged
merged 1 commit into from
Apr 2, 2020
Merged

Fix Stdlib::HTTPSUrl type name #330

merged 1 commit into from
Apr 2, 2020

Conversation

laugmanuel
Copy link
Member

@laugmanuel laugmanuel commented Apr 2, 2020

The datatype has to be HTTPSUrl instead of Httpsurl to not break the foreman-installer if using the params.pp directly:

[root@foreman4xng ~]# foreman-installer --scenario custom --noop --verbose
[FATAL 2020-04-02T08:01:02 fatal] Unable to continue because of: unknown data type Stdlib::Httpsurl

I'm not really sure why this works when just including the class without specifying the parameters explicitly (like in https://github.com/theforeman/puppet-katello/blob/master/manifests/init.pp#L159-163)

see https://github.com/puppetlabs/puppetlabs-stdlib#stdlibhttpsurl

Copy link
Member

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The problem is that Kafo is case sensitive when it comes to types while Puppet isn't. We have https://github.com/theforeman/kafo_module_lint but don't apply this to all classes.

@ekohl ekohl merged commit d4b09b8 into theforeman:master Apr 2, 2020
@wbclark wbclark added Bug and removed Needs testing labels May 14, 2020
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants