-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Support manage_httpd to allow Pulp in a standalone setup (followup) #337
Support manage_httpd to allow Pulp in a standalone setup (followup) #337
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can bikeshed about names (manage_httpd
doesn't seem too clear since Apache is managed either way) but since we plan on Removing Pulp 2 after Foreman 2.2 I don't mind either way. This particular class is not typically used by most users since the installer doesn't expose it.
Let me know if you want me to merge this as is or if you want to rename manage_httpd
.
@ekohl sure we can rename the parameter. What do you think about |
You could say that For now I'm thinking the easiest would be |
Sounds good to me. I changed the name of the variable and improved the parameter documentation accordingly. |
(I'll let the tests continue, but the code looks good to merge). |
Follow up to #312
This PR enables Pulp to exist as a standalone system and therefore enables split deployments.
The default behaviour does not change in any way. It it explicitly required to set a least manage_httpd to true.
Note: The original PR is #312. Because the source branch was missing, I needed to open a new PR with an existing branch I can push to.