Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Support manage_httpd to allow Pulp in a standalone setup (followup) #337

Merged
merged 3 commits into from
May 4, 2020
Merged

Support manage_httpd to allow Pulp in a standalone setup (followup) #337

merged 3 commits into from
May 4, 2020

Conversation

laugmanuel
Copy link
Member

@laugmanuel laugmanuel commented May 4, 2020

Follow up to #312

This PR enables Pulp to exist as a standalone system and therefore enables split deployments.

The default behaviour does not change in any way. It it explicitly required to set a least manage_httpd to true.

Note: The original PR is #312. Because the source branch was missing, I needed to open a new PR with an existing branch I can push to.

@laugmanuel laugmanuel changed the title Support manage_httpd to allow Pulp in a standalone setup Support manage_httpd to allow Pulp in a standalone setup (followup) May 4, 2020
Copy link
Member

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can bikeshed about names (manage_httpd doesn't seem too clear since Apache is managed either way) but since we plan on Removing Pulp 2 after Foreman 2.2 I don't mind either way. This particular class is not typically used by most users since the installer doesn't expose it.

Let me know if you want me to merge this as is or if you want to rename manage_httpd.

@laugmanuel
Copy link
Member Author

@ekohl sure we can rename the parameter. What do you think about manage_httpd_standalone or something like that? This would also indicate the change in behaviour.

@ekohl
Copy link
Member

ekohl commented May 4, 2020

You could say that pulp is standalone, but it's more about a vhost than httpd (yes, badly named in puppet-pulp) so Boolean $manage_vhost_standalone? However, I don't really know what it would do if you say false so I was thinking in the direction of Enum['foreman', 'pulp'] $vhost. It's complicated.

For now I'm thinking the easiest would be Boolean $manage_vhost_standalone and document that it's part of the Foreman vhost when it's not standalone in the parameter documentation. What do you think?

@laugmanuel
Copy link
Member Author

Sounds good to me. I changed the name of the variable and improved the parameter documentation accordingly.

@ekohl
Copy link
Member

ekohl commented May 4, 2020

(I'll let the tests continue, but the code looks good to merge).

@ehelms ehelms merged commit 9ce6975 into theforeman:master May 4, 2020
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants