Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

never deploy /pub, that's handled by f_p_c now #362

Merged
merged 1 commit into from
Oct 2, 2020

Conversation

evgeni
Copy link
Member

@evgeni evgeni commented Sep 11, 2020

No description provided.

@ehelms
Copy link
Member

ehelms commented Sep 11, 2020

This looks mostly like a clean-up and re-factor of which I am OK. The ultimate goal should be for puppet-foreman_proxy_content to be the one and only that deploys the pub dir. The problem, which I think was pointed out elsewhere, is the difference in vhost's and the ports we deploy on to. (And who is involved in configuring all of that, Foreman or Pulp)

Do you think we can tackle the centralization of it or does this provide enough value to keep EL8 moving forward?

Copy link
Member

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have some doubts about this. As @ehelms said, we are planning to work on this and moving twice feels a bit awkward. Especially if long term it's going to disappear completely.

manifests/pub.pp Outdated Show resolved Hide resolved
@evgeni
Copy link
Member Author

evgeni commented Sep 11, 2020

What's the timeline for the centralization? Today, on EL8 there is no /pub so no client can be subscribed as they have no way to obtain the certs, which makes it pretty much an EL8 blocker. I am not 100% sure when we want to have katello (server) support for el8, but probably sooner than later? content proxy is another beast to tackle then.

@evgeni
Copy link
Member Author

evgeni commented Sep 14, 2020

FWIW, this is not the only issue I am facing on EL8 (like e.g. https://projects.theforeman.org/issues/30832) but it's kind of the root of everything :D

@evgeni evgeni changed the title always deploy a /pub config as part of the foreman vhost never deploy /pub, that's handled by f_p_c now Sep 25, 2020
Copy link
Member

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 as long as the FPC PR is merged.

@ehelms ehelms merged commit 45b5dc3 into theforeman:master Oct 2, 2020
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants