Fixes #7802 - allow user to be passed into qpid module #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -2,9 +2,10 @@ | |||
| class katello::qpid ( | |||
| $client_cert = undef, | |||
| $client_key = undef, | |||
| $katello_user = $katello::user | |||
There was a problem hiding this comment.
I think it would be better to reference $katello::params::user here.
There was a problem hiding this comment.
well… we should also pass the $katello::user param at https://github.com/dustint-rh/puppet-katello/blob/configure_qpid_user/manifests/init.pp#L100, as $katello::params::user is just the default, not the current value used in other areas
There was a problem hiding this comment.
I don't know if it really matters here. You're still not guaranteed that katello::params is included.
dustints
force-pushed
the
configure_qpid_user
branch
from
2c01ae5 to
4f6ee8d
Compare
|
APT |
|
👍 |
|
ACK pending squash and green tests |
dustints
force-pushed
the
configure_qpid_user
branch
from
597ad87 to
1b761b6
Compare
dustints
pushed a commit
that referenced
this pull request
Oct 6, 2014
Fixes #7802 - allow user to be passed into qpid module
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.