Fixes #33830 - Drop content type settings #433
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 2, 2021
Merged
|
Some additional unit test fixes needed 👍 on the simplification |
Since Katello 4.2 these are no longer needed and determined dynamically.
ekohl
force-pushed
the
drop-content-type-settings
branch
from
9cc75b2 to
9643aec
Compare
ehelms
approved these changes
Nov 3, 2021
|
@ekohl do you want to go backwards incompatible with this? or enhancement with README scoping for supported Katello version? |
|
I thought about scoping for the supported Katello version in README. It was unclear to me what we actually do support in this module. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since Katello 4.2 these are no longer needed and determined dynamically.