Fixes #35005: Drop setting Pulp client certificate settings #450
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These settings were introduced with Pulp 2 and carried over to Pulp 3 before we introduced client authentication support in smart_proxy_pulp. The support for using Foreman client certificates to talk to Pulp 3 was introduced in Foreman 3.0. This is now safe to drop.
This was referenced Jun 2, 2022
chris1984
approved these changes
Jun 2, 2022
|
Current acceptance failures are due to nightly being broken, and this change can fix builds. So this is a bit of a chicken-n-egg problem. I ran these tests locally against the Koji staging repositories and given that was green -- choosing to merge. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These settings were introduced with Pulp 2 and carried over to Pulp
3 before we introduced client authentication support in smart_proxy_pulp.
The support for using Foreman client certificates to talk to Pulp 3 was
introduced in Foreman 3.0. This is now safe to drop.