Fixes #9483 - notify the services after gutterball configuration changes #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -13,5 +13,6 @@ | |||
| foreman_plugins_dir => $katello::config_dir, | |||
| foreman_user => $katello::user, | |||
| foreman_group => $katello::group, | |||
| notify => [Service['foreman-tasks'], Service['foreman']], | |||
There was a problem hiding this comment.
Often the foreman service is run through apache. It's be better to notify Class['foreman::service'] which does the right thing for you.
|
👍 but tests are broken because puppet-pulp dropped puppet 2.7 support. @ehelms I think you want to remove puppet 2.7 from the test matrix. |
|
Removing 2.7 support - #63 |
|
Rebased |
|
👍 yay green tests |
|
ACK |
iNecas
added a commit
that referenced
this pull request
Feb 24, 2015
Fixes #9483 - notify the services after gutterball configuration changes
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.