Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

include apache::mod::setenvif #273

Merged
merged 2 commits into from
May 6, 2022
Merged

Conversation

wbclark
Copy link
Contributor

@wbclark wbclark commented Apr 28, 2022

puppet-katello included this as of
theforeman/puppet-katello@afc08e3

@wbclark
Copy link
Contributor Author

wbclark commented Apr 28, 2022

This is needed due to theforeman/foreman-installer#754 and fixed in katello with theforeman/puppet-katello#445

@sjha4
Copy link
Contributor

sjha4 commented Apr 29, 2022

Not to hijack this PR but putting it here since we have infrastructure gurus on the thread. There's another issue in the repo that is breaking dev boxes:

The package 'cyrus-sasl-plain' is declared twice for dev box:

  1. https://github.com/theforeman/puppet-katello_devel/blob/master/manifests/install.pp
  2. https://github.com/theforeman/puppet-qpid/blob/master/manifests/install.pp#L21

This throws a duplicate declaration error on vagrant up of dev boxes.

@chris1984
Copy link
Member

Not to hijack this PR but putting it here since we have infrastructure gurus on the thread. There's another issue in the repo that is breaking dev boxes:

The package 'cyrus-sasl-plain' is declared twice for dev box:

  1. https://github.com/theforeman/puppet-katello_devel/blob/master/manifests/install.pp
  2. https://github.com/theforeman/puppet-qpid/blob/master/manifests/install.pp#L21

This throws a duplicate declaration error on vagrant up of dev boxes.

Can confirm I hit this as well, I usually have to have vagrant not delete the dev box and i go in and delete it out of qpid then the installer runs fine.

@sjha4
Copy link
Contributor

sjha4 commented May 5, 2022

Is the test failure related? We should merge this if not.

@ehelms ehelms merged commit 21bc920 into theforeman:master May 6, 2022
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants