Fixes #26323 - Remove max_tasks_per_child setting #362
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Was this setting removed from Pulp or have they deprecated it's use? If not, I think we need to keep this here and only remove it form modules that use this module. |
|
Proxy pr: |
|
@ehelms the feature is still there just not being moved over with Pulp 3. I am fine with that suggestion on just removing it from our stuff. |
|
I agree with @ehelms that as long as it's a feature, it's fine to keep it in. We don't need to expose it as a top level parameter though. |
|
Closing based on discussions, will just keep the katello/proxy-content one open and make a migration for the installer. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Will open up Refs prs to the other modules that have this setting including katello-devel so they can be merged after this one is accepted.