Use qpid::tools class #97
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -15,7 +15,7 @@ | |||
| Service[$broker_service] -> Exec['migrate_pulp_db'] | |||
| } else { | |||
| if $pulp::messaging_transport == 'qpid' { | |||
| package { 'qpid-tools': ensure => installed } -> Class['pulp::service'] | |||
| Class['qpid::tools'] -> Class['pulp::service'] | |||
There was a problem hiding this comment.
You gave the example though of qpid being external to the pulp - does it need qpid-tools still on the pulp in that case?
If so, you can include qpid::tools here too
There was a problem hiding this comment.
I think this needs to be present even on a pulp server before migrations are run? I can do further testing to try to pinpoint this better.
There was a problem hiding this comment.
Right but Class['qpid::tools'] isn't including the class, it's just forcing the dependency if it's present.
I think you need to do include qpid:tools before this line to account for the case you put qpid on a different server, which doesn't apply to us but could for others.
Switches to using qpid::tools class instead of ensuring package directly to prevent duplicate resource errors
|
Good call -- updated |
|
APT |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switches to using qpid::tools class instead of ensuring package
directly to prevent duplicate resource errors