Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

switchToParentFrame errors in IE 11 (but not 10) #1081

Closed
maxbeatty opened this issue Jan 28, 2020 · 3 comments
Closed

switchToParentFrame errors in IE 11 (but not 10) #1081

maxbeatty opened this issue Jan 28, 2020 · 3 comments
Assignees
Labels
bug Something that's not working as intended effort-low Should be pretty quick priority-medium This should get done, but it's not a high priority repo-leadfoot Resolution applies to @theintern/leadfoot

Comments

@maxbeatty
Copy link
Contributor

Expected behavior

switchToParentFrame should work consistently across browsers

Current behavior

"Command not found" when POST /session/{{session_id}}/frame/parent

2020-1-28 19:20:19:792 REQUEST [2020-1-28 19:20:19:792] POST /session/24f3560ccc2496d466c29fff3f40410628bd04ed/frame/parent {}
2020-1-28 19:20:19:799 RESPONSE {"status":404,"sessionId":"<no session>","value":"Command not found: POST /session/24f3560ccc2496d466c29fff3f40410628bd04ed/frame/parent"}

Possible solution

Maybe there's a workaround with alternate syntax?

Steps to reproduce (for bugs)

  1. example repo: https://github.com/maxbeatty/example-intern
  2. checkout
  3. yarn install
  4. put browserstack credentials in .env or export in shell
  5. yarn test --browserstack --browser ie --browser-version 11
  6. ci build
  7. happy to share any logs or access to BrowserStack builds

Environment

Intern version: 4.8.0
Node version: circleci/node:lts
NPM version: yarn v1.21.1
Browser version: Internet Explorer 11

@jason0x43
Copy link
Member

From the error it looks like the session may have become invalid ("sessionId":"<no session>"). POSTing to /session/<session id>/frame/parent is a valid command for both W3C webdriver and JsonWireProtocol, so it should work in all cases.

Does this always happen, or only sometimes?

@jason0x43 jason0x43 added needs-verification Needs to be verified bug Something that's not working as intended effort-low Should be pretty quick priority-medium This should get done, but it's not a high priority and removed needs-verification Needs to be verified labels Jan 28, 2020
@jason0x43
Copy link
Member

Ok, I see what's happening, at least partly. Neither IE10 nor 11 support the /frame/parent command, but we're only executing the fallback code for IE10.

@jason0x43 jason0x43 added the repo-leadfoot Resolution applies to @theintern/leadfoot label Jan 28, 2020
@maxbeatty
Copy link
Contributor Author

if you can point me to the current fallback, I could try to make a PR to fix for IE 11

@jason0x43 jason0x43 self-assigned this Jan 28, 2020
jason0x43 added a commit to jason0x43/intern that referenced this issue Jul 7, 2020
- Set the brokenParentFrameSwitch flag for IE
- Update session.switchToParentFrame to auto-set the
  brokenParentFrameSwitch flag if a frame switch call fails and it
  wasn't already set
- Update the feature test to use a direct POST call instead of calling
  session.switchToParentFrame
- Re-enable the self test

resolves theintern#1081
jason0x43 added a commit to jason0x43/intern that referenced this issue Jul 13, 2020
- Set the brokenParentFrameSwitch flag for IE
- Update session.switchToParentFrame to auto-set the
  brokenParentFrameSwitch flag if a frame switch call fails and it
  wasn't already set
- Update the feature test to use a direct POST call instead of calling
  session.switchToParentFrame
- Re-enable the self test

resolves theintern#1081
jason0x43 added a commit that referenced this issue Jul 21, 2020
- Set the brokenParentFrameSwitch flag for IE
- Update session.switchToParentFrame to auto-set the
  brokenParentFrameSwitch flag if a frame switch call fails and it
  wasn't already set
- Update the feature test to use a direct POST call instead of calling
  session.switchToParentFrame
- Re-enable the self test

resolves #1081
jason0x43 added a commit that referenced this issue Aug 10, 2020
- Set the brokenParentFrameSwitch flag for IE
- Update session.switchToParentFrame to auto-set the
  brokenParentFrameSwitch flag if a frame switch call fails and it
  wasn't already set
- Update the feature test to use a direct POST call instead of calling
  session.switchToParentFrame
- Re-enable the self test

resolves #1081
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
bug Something that's not working as intended effort-low Should be pretty quick priority-medium This should get done, but it's not a high priority repo-leadfoot Resolution applies to @theintern/leadfoot
Projects
None yet
Development

No branches or pull requests

2 participants