Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

geezer branch: getIndexOf incorrect fallback #27

Closed
jdalton opened this issue May 7, 2013 · 3 comments
Closed

geezer branch: getIndexOf incorrect fallback #27

jdalton opened this issue May 7, 2013 · 3 comments
Assignees
@bitpshr
Labels
bug Something that's not working as intended geezer Intern for very old browsers
Milestone
1.1

Comments

@jdalton
Copy link

jdalton commented May 7, 2013

By spec Array#indexOf should skip holes in arrays. The current fallback will treat holes in arrays as undefined instead.
@jdalton
Copy link
Author

jdalton commented May 7, 2013

Related to #26

@ghost ghost assigned bitpshr May 17, 2013
@bitpshr bitpshr mentioned this issue May 17, 2013
Closed
bitpshr added a commit that referenced this issue May 20, 2013
@bitpshr @csnover
Fix getIndexOf fallback, general assert module cleanup, refs #27
10a49df
@csnover
Copy link
Member

csnover commented May 20, 2013

Fixed by 10a49df.

@csnover csnover closed this as completed May 20, 2013
@jdalton
Copy link
Author

jdalton commented May 20, 2013

I think there is an issue w/ the patch, I've commented on it over at 10a49df.

@vladikoff vladikoff mentioned this issue May 25, 2014
Closed
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@bitpshr bitpshr

Labels
bug Something that's not working as intended geezer Intern for very old browsers
Projects
None yet
Milestone
1.1
Development

No branches or pull requests
3 participants
@jdalton @csnover @bitpshr