-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
"POST /execute" breaks on updated drivers when using Leadfoot directly. #143
Comments
When using "POST /execute", the command fails with a "Command not found error." I monkey-patched my local fork just to check if the "POST /execute/sync" endpoint works, and it does. My environment: Mac OSX |
There's not a way (that I'm aware of) to query the webdriver about its own version, so we'll probably need to handle it via a custom feature and a fallback behavior in the Basically, if leadfoot tries to call |
Sounds good. I will get on it. |
Can you assign to me? Or is that not possible? |
This has been fixed via the referenced PRs/ |
When using Leadfoot by itself, GeckoDriver > 16.0 breaks when using the "POST /execute" function.
The webdriver spec has updated this to be "POST /execute/sync" and GeckoDriver updated that a few versions ago. I wanted to get your thoughts on how to handle and I will post a fix.
Should we:
1.) Create a conditional to check the version of the driver edit the endpoint so as not to break drivers that haven't updated their spec yet (i.e. Chromedriver).
2.) Something else I haven't thought of.
The text was updated successfully, but these errors were encountered: