Validation for response in ff58 #141
Conversation
|
|
cuff-links
force-pushed
the
validation_for_response_in_ff58
branch
from
679b155 to
460c8ed
Compare
|
@dylans Yep. One commit was in the wrong email. My bad. Thanks for the help. |
|
Reopening as it hasn't landed in Leadfoot yet. |
Server.js
Outdated
| var responseData = null; | ||
| var sessionId = null; | ||
| // At least geckodriver 0.19.0 returns the response data in a 'value.capabilities' | ||
| // property, whereas Selenium does not. |
There was a problem hiding this comment.
Looks like there's a problem with the whitespace lines 369 - 375. I think this code uses spaces to indent whereas the rest of the file uses tabs.
cuff-links
force-pushed
the
validation_for_response_in_ff58
branch
from
fbd30ab to
621a650
Compare
| @@ -363,12 +363,19 @@ Server.prototype = { | |||
| desiredCapabilities: desiredCapabilities, | |||
| requiredCapabilities: requiredCapabilities | |||
| }).then(function (response) { | |||
| // At least geckodriver 0.15.0 returns the response data in a 'value' property, whereas Selenium does not. | |||
| if (response.value && response.value.sessionId) { | |||
There was a problem hiding this comment.
This case is no longer covered (where the structure would have response.value.sessionId && response.value.value).
{
value: {
sessionId: 123
value: {
// ...
}
}
}
There was a problem hiding this comment.
@jason0x43 Fixed. I think we should be good now. Thanks for catching that.
Server.js
Outdated
| var sessionId = null; | ||
| // At least geckodriver 0.19.0 returns the response data in a 'value.capabilities' | ||
| // property, whereas Selenium does not. | ||
| if (!response.sessionId && response.value.capabilities) { |
There was a problem hiding this comment.
Rather than check for !response.sessionId, consider checking for response.value.sessionId && response.value.capabilities.
cuff-links
force-pushed
the
validation_for_response_in_ff58
branch
from
5c97ddc to
32742bc
Compare
cuff-links
force-pushed
the
validation_for_response_in_ff58
branch
from
32742bc to
d6a7824
Compare
|
@jason0x43 The edits have been made. |
Server.js
Outdated
| var responseData = null; | ||
| var sessionId = null; | ||
| // At least geckodriver 0.19.0 returns the response data in a 'value.capabilities' | ||
| // property, whereas Selenium does not. |
There was a problem hiding this comment.
Somehow my commit to fix the mixed use of tabs and spaces in this and the next few lines was lost with the recent push...
|
@dylans @jason0x43 I set webstorm up for smart tabs with 4 indentation. I hope this worked. |
|
Merged in b861870. Thanks! |
Fixes #139