Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Switch to Poetry for dependency and build management #679

Merged
merged 4 commits into from
Mar 6, 2024

Conversation

rzvoncek
Copy link
Contributor

@rzvoncek rzvoncek commented Nov 1, 2023

Fixes #555.
Fixes #667.
Fixes #665.
Fixes #712.
Fixes #706.

In attempt to stay somewhat recent, this PR switches Medusa's dependencies and (Python) packaging to be managed by Poetry. The debian package build is updated to reflect that too.

  • The CI is green.
  • Building the deb package on a fresh focal (20.04) works to a point that installing that package on another focal node works too (did a backup with it).
  • Installing medusa with pip straight from this branch works too (on a focal instance), but I did not try to do a backup.
  • Installing medusa offline works too according to the updated documentation (tested on both ubuntu and RHEL).
  • I've also managed to push medusa into the test pypi. I could not install it from there because all the deps are not in the test pypi.

@rzvoncek rzvoncek force-pushed the radovan/poetry branch 9 times, most recently from 1aafadb to 6da3e78 Compare November 1, 2023 16:15
Copy link

codecov bot commented Nov 1, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.14%. Comparing base (b0cc958) to head (6ccef08).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #679   +/-   ##
=======================================
  Coverage   80.14%   80.14%           
=======================================
  Files          52       52           
  Lines        4708     4708           
  Branches      958      958           
=======================================
  Hits         3773     3773           
  Misses        906      906           
  Partials       29       29           
Files Coverage Δ
medusa/service/grpc/restore.py 44.82% <ø> (ø)

@rzvoncek rzvoncek force-pushed the radovan/poetry branch 8 times, most recently from 62fd201 to bbf8e4a Compare November 3, 2023 08:32
Copy link

sonarqubecloud bot commented Nov 3, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell B 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@rzvoncek rzvoncek force-pushed the radovan/poetry branch 11 times, most recently from 10cf615 to 19fcfb6 Compare February 28, 2024 15:26
@rzvoncek rzvoncek force-pushed the radovan/poetry branch 3 times, most recently from 1b3ded8 to 60101de Compare February 29, 2024 07:14
@rzvoncek rzvoncek changed the title WIP Move to Poetry Switch to Poetry for dependency and build management Feb 29, 2024
@rzvoncek rzvoncek force-pushed the radovan/poetry branch 3 times, most recently from 235f5c4 to 7096909 Compare February 29, 2024 13:27
@rzvoncek rzvoncek marked this pull request as ready for review February 29, 2024 14:51
Copy link
Contributor

@adejanovski adejanovski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great 👍

k8s/README.md Outdated Show resolved Hide resolved
@adejanovski adejanovski linked an issue Mar 6, 2024 that may be closed by this pull request
Co-authored-by: Alexander Dejanovski <adejanovski@gmail.com>
Copy link

sonarqubecloud bot commented Mar 6, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
2 Security Hotspots

See analysis details on SonarCloud

@rzvoncek rzvoncek merged commit 36cc3fd into master Mar 6, 2024
31 of 32 checks passed
@rzvoncek rzvoncek deleted the radovan/poetry branch June 12, 2024 09:49
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
2 participants