Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Prevent recursive DSE snapshots #704

Merged
merged 1 commit into from
Jan 15, 2024
Merged

Conversation

rzvoncek
Copy link
Contributor

Fixes #703.

Copy link

codecov bot commented Jan 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (4ed1fd5) 80.18% compared to head (3869c50) 80.12%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #704      +/-   ##
==========================================
- Coverage   80.18%   80.12%   -0.06%     
==========================================
  Files          52       52              
  Lines        4688     4700      +12     
  Branches      953      956       +3     
==========================================
+ Hits         3759     3766       +7     
- Misses        900      905       +5     
  Partials       29       29              
Files Coverage Δ
medusa/cassandra_utils.py 86.11% <100.00%> (+0.21%) ⬆️
...dusa/service/snapshot/nodetool_snapshot_service.py 68.00% <100.00%> (-17.72%) ⬇️

@rzvoncek rzvoncek force-pushed the radovan/fix-dse-snapshots branch 2 times, most recently from c54788f to 9ee5d1a Compare January 12, 2024 16:57
@rzvoncek rzvoncek force-pushed the radovan/fix-dse-snapshots branch from 9ee5d1a to 3869c50 Compare January 15, 2024 09:30
Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@rzvoncek rzvoncek merged commit c8609c8 into master Jan 15, 2024
33 checks passed
rzvoncek added a commit that referenced this pull request Jan 30, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DSE snapshots are recursive and therefore broken
2 participants