Make grpc's AsynBackup trully Async #720
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #720 +/- ##
==========================================
- Coverage 80.14% 80.12% -0.02%
==========================================
Files 52 52
Lines 4708 4719 +11
Branches 958 959 +1
==========================================
+ Hits 3773 3781 +8
- Misses 906 909 +3
Partials 29 29
|
rzvoncek
force-pushed
the
radovan/truly-async-grpc
branch
5 times, most recently
from
d43ebed to
650f0b7
Compare
rzvoncek
force-pushed
the
radovan/truly-async-grpc
branch
from
650f0b7 to
94dfc61
Compare
|
adejanovski
approved these changes
Mar 15, 2024
This was referenced Mar 20, 2024
Closed
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes k8ssandra/k8ssandra-operator#1183
Fixes k8ssandra/k8ssandra-operator#1231
Fixes #721
The GRPC's AsyncBackup endpoint was not async. It was blocking until the backup finished. This PR fixes that, and then adjusts the ITs so that they work with the new async implementation.
I've also touched the logging during ITs so that we don't have thousands of lines about Cassandra not being yet available.
I've also touched how we build the Medusa container image for k8s; it now has the Medusa entry point on the system path again.
Aside from the ITs, I've tested this by: