Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Update GRPC_HEALTH_PROBE_VERSION to version 0.4.25 #724

Merged
merged 1 commit into from
Mar 22, 2024

Conversation

AlexsandroRotundo
Copy link
Contributor

Update GRPC_HEALTH_PROBE_VERSION to version 0.4.25

Copy link

No linked issues found. Please add the corresponding issues in the pull request description.
Use GitHub automation to close the issue when a PR is merged

Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@AlexsandroRotundo
Copy link
Contributor Author

AlexsandroRotundo commented Mar 15, 2024

Issue: #725

@AlexsandroRotundo
Copy link
Contributor Author

AlexsandroRotundo commented Mar 16, 2024

I pushed a stupid modification about the upgrade of the GRPC HEALTH PROBE VERSION. Unfortunately, I got a pipeline failure in these tests:

  k8ssandra-e2e-tests:
    needs: [build]
    runs-on: ubuntu-latest
    strategy:
      matrix:
        e2e_test:
          - CreateSingleMedusaJob
          - CreateSingleDseSearchDatacenterCluster
      fail-fast: false
    name: k8ssandra-${{ matrix.e2e_test }}
    env:
      CGO_ENABLED: 0
      KUBECONFIG_FILE: "./build/kind-kubeconfig"
      CONTROL_PLANE: kind-k8ssandra-0
      DATA_PLANES: kind-k8ssandra-0
    steps:
      - name: Raise open files limit
        run: |
          echo fs.file-max=1000000 | sudo tee -a /etc/sysctl.conf && sudo sysctl -p
          echo fs.inotify.max_user_instances=1280 | sudo tee -a /etc/sysctl.conf && sudo sysctl -p
          echo fs.inotify.max_user_watches=655360 | sudo tee -a /etc/sysctl.conf && sudo sysctl -p
          ulimit -a
      - name: Free diskspace by removing unused packages
        run: |
          sudo rm -rf /usr/local/lib/android
          sudo rm -rf /usr/share/dotnet
      - name: Set up Docker Buildx
        uses: docker/setup-buildx-action@v1
      - name: Login to DockerHub
        uses: docker/#-action@v2
        with:
          username: ${{ secrets.K8SSANDRA_DOCKER_HUB_USERNAME }}
          password: ${{ secrets.K8SSANDRA_DOCKER_HUB_PASSWORD }}

I believe that username and password are missing in the secret configuration of my fork.
Someone could help me to fix this problem to contribute in the maintenance of the project, please?

Thank you in advance.

@adejanovski
Copy link
Contributor

Hi @AlexsandroRotundo, external PRs aren't allowed to access secrets indeed. I'll push a branch based on your PR to get CI running.

@adejanovski
Copy link
Contributor

Here it is.

Copy link
Contributor

@adejanovski adejanovski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change is working nicely in #728 . We're good moving forward with this.
Thanks @AlexsandroRotundo !

@adejanovski adejanovski merged commit 44d6e6c into thelastpickle:master Mar 22, 2024
52 of 59 checks passed
@rzvoncek rzvoncek mentioned this pull request Apr 3, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants