Add support for using an attached GCE service account #827
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Thanks for this PR @andyfoston, that's definitely something we want to support. |
rzvoncek
approved these changes
Dec 16, 2024
There was a problem hiding this comment.
Hi. I've tested this manually, it works like a charm.
The failing integration-tests (3.9, local, 2.2.19, 8.0.252) are a know issue, I'm fixing them elsewhere.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support using service accounts that are attached to a GCE instance, rather than requiring a service account key to be present.
The
gcloud-aiolibrary supports using a service account that is assigned to a VM by default just by omitting theservice_fileparameter (or by setting it toNone).Removing this requirement means that the service account key does not need to be manually rotated, as the assigned service account credentials provided by the GCE metadata API are automatically rotated frequently.
Closes: #833