#1682 whatsAppCloudTextParameterTemplate - fix problem with spanish #1683
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…problem with spanish
Fabilin
reviewed
Jul 11, 2024
| @@ -328,7 +328,7 @@ fun <T : Bus<T>> T.whatsAppCloudTextParameterTemplate( | |||
| typeParameter: CharSequence?, | |||
| textButton: CharSequence? | |||
| ): TextParameter = TextParameter( | |||
| type = ParameterType.valueOf(translate(typeParameter).toString()), | |||
| type = ParameterType.valueOf((typeParameter).toString()), | |||
There was a problem hiding this comment.
Why not just take the ParameterType as argument to the method instead of going through the valueOf?
added 2 commits
August 20, 2024 14:25
…ParameterType in parameter instead of charSequence
…ParameterType in parameter instead of charSequence + add deprecated method
Fabilin
approved these changes
Aug 20, 2024
vsct-jburet
approved these changes
Aug 20, 2024
morgandiverrez
pushed a commit
that referenced
this pull request
Aug 26, 2024
…1683) * #1682 whatsAppCloudTextParameterTemplate - fix problem with spanish * #1682 whatsAppCloudTextParameterTemplate - use ParameterType in parameter instead of charSequence * #1682 whatsAppCloudTextParameterTemplate - use ParameterType in parameter instead of charSequence + add deprecated method --------- Co-authored-by: charles_moulhaud <charles_moulhaud@connect-tech.sncf>
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.