fixes #1829 bot_engine: rename applicationId to connectorId #1830
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #1829 by deprecating the
applicationIdfield in theBusinterface and in the variousActionclasses, and replacing it with a more adequateconnectorId.Backwards compatibility
This PR aims at retaining full source and binary compatibility with existing applications.
In order to keep source compatibility with applications that relied on named parameters, deprecated overloads have been introduced for every public constructor with an
applicationIdparameter. These deprecated overloads have an additional dummy_deprecatedConstructorargument to get around the otherwise conflicting erased signatures.This change has been tested with several API-based bots that are affected by the renaming. All of them kept compiling and running without immediate changes. The renaming should be especially painless for developers who use appropriate kotlin IDEs, thanks to the presence of the
ReplaceWithannotation.