-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Update GitHub Actions workflows to latest #34
Conversation
The CI for this pull request is failing (as intended) currently. #35 should fix these. |
Wouldnt keeping the theos version fixed be better to prevent a theos update breaking orion builds? |
Yes, usually it's a good idea to version-pin dependencies, however theos is designed to be highly backward compatible. |
let's merge #35 first and make CI green again, will review this after that. |
A matrix would be more difficult to manage because all the artifacts would need to be uploaded and then downloaded to attach to the release
The `actions/create-release` action is no longer maintained. Also migrate to workflow specific-tokens instead of an access token stored in Secrets
Using the a build workflow closer to the release workflow means we're testing the code we're actually deploying
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
What does this implement/fix? Explain your changes.
Changes from commits:
actions/checkout
tov4
theos/theos
upstreamactions/checkout
action is no longer maintainedDoes this close any currently open issues?
No
Any relevant logs, error output, etc?
Where has this been tested?
Operating System: macOS 11
Platform: macOS
Target Platform: iOS