Fix incorrect parenthesis order (#13)

thephpleague · Jan 14, 2020 · 128893c · 128893c
1 parent c13eefe
commit 128893c
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 1 deletion.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -7,6 +7,10 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ## [Unreleased][unreleased]
 
+### Fixed
+
+ - Fixed incorrect parenthesis order (#13)
+
 ## [1.0.0] - 2019-06-29
 
 No changes have been introduced since 1.0.0-beta3.

diff --git a/src/UrlAutolinkProcessor.php b/src/UrlAutolinkProcessor.php
@@ -105,7 +105,7 @@ private static function processAutolinks(Text $node, $regex)
             // Does the URL need its closing paren chopped off?
             if (\substr($content, -1) === ')' && self::hasMoreCloserParensThanOpeners($content)) {
                 $content = \substr($content, 0, -1);
-                $leftovers .= ')';
+                $leftovers = ')' . $leftovers;
             }
 
             self::addLink($node, $content);

diff --git a/tests/UrlAutolinkProcessorTest.php b/tests/UrlAutolinkProcessorTest.php
@@ -62,6 +62,7 @@ public function dataProviderForAutolinkTests()
         yield ['www.google.com/search?q=Markup+(business)', '<p><a href="http://www.google.com/search?q=Markup+(business)">www.google.com/search?q=Markup+(business)</a></p>'];
         yield ['(www.google.com/search?q=Markup+(business))', '<p>(<a href="http://www.google.com/search?q=Markup+(business)">www.google.com/search?q=Markup+(business)</a>)</p>'];
         yield ['www.google.com/search?q=(business))+ok', '<p><a href="http://www.google.com/search?q=(business))+ok">www.google.com/search?q=(business))+ok</a></p>'];
+        yield ['(https://www.example.com/test).', '<p>(<a href="https://www.example.com/test">https://www.example.com/test</a>).</p>'];
 
         // Tests involving semi-colon endings
         yield ['www.google.com/search?q=commonmark&hl=en', '<p><a href="http://www.google.com/search?q=commonmark&amp;hl=en">www.google.com/search?q=commonmark&amp;hl=en</a></p>'];